[VL] Fixed iceberg table properties config logic#12221
Merged
Merged
Conversation
infvg
changed the title
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
changed the title
zhouyuan
approved these changes
Jun 2, 2026
Member
|
This aligns the java iceberg behavior |
infvg
force-pushed
the
sqlconffix
branch
2 times, most recently
from
9119bc7 to
e7fc635
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how Velox Iceberg native write derives and forwards write-related properties so that session-level Spark SQLConf settings take precedence, with Iceberg table properties used as a fallback when the session config is not explicitly set.
Changes:
- Update Iceberg write exec helpers to source Parquet page size from table properties and target file size from Iceberg write conf.
- Fix Velox Iceberg writer property propagation logic to only inject fallback values when the corresponding SQLConf key is not set.
- Add a (currently disabled) regression test intended to validate
write.target-file-size-bytesbehavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergWriteExec.scala | Adjusts how Parquet page size and target file size values are sourced for native write configuration. |
| backends-velox/src-iceberg/main/scala/org/apache/gluten/execution/AbstractIcebergWriteExec.scala | Changes property injection condition to respect explicitly set SQLConf values and only fall back otherwise. |
| backends-velox/src-iceberg/test/scala/org/apache/gluten/execution/enhanced/VeloxIcebergSuite.scala | Adds a regression test intended to verify target file sizing behavior (currently structured as disabled). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+468
to
+470
| ignore("disabled test") { | ||
| test("iceberg native write respects target file size bytes") { | ||
| withTable("iceberg_small_target_tbl") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic overrode SQLConf property with TableProperty, while not setting any value when SQLConf not set. Now it will prioritize SQLConf, then TableProperty